How should I structure DML operations to avoid "DML inside loop" violations when using lists?
Answer
To avoid "DML inside loop" violations when using lists:
- Collect the records that need to be inserted, updated, or deleted into a list during the loop iteration.
- Perform all DML operations outside of the loop by executing the DML operation on the entire list in a single statement after the loop completes.
This approach improves performance and helps avoid exceeding governor limits.
How should I structure DML operations to avoid "DML inside loop" violations when using lists?
Recommended Answer Update
To avoid "DML inside loop" violations when using lists:
- Collect the records that need to be inserted, updated, or deleted into a list during the loop iteration.
- Perform all DML operations outside of the loop by executing the DML operation on the entire list in a single statement after the loop completes.
This approach improves performance and helps avoid exceeding governor limits.
Reasoning
The FAQ content is accurate and well-structured, addressing a fundamental Apex best practice. The main improvement is removing the bullet point formatting from the introductory sentence to improve readability and flow. The content flows better when the introductory sentence is a complete statement followed by the bulleted instructions.
I selected ApexCRUDViolation because this rule is directly related to DML operations in Apex code. While the FAQ focuses on the performance and governor limit aspects of avoiding DML inside loops, proper DML structuring (as described in the FAQ) also supports secure CRUD operations by enabling proper bulk processing patterns. The FAQ's guidance on collecting records into lists and performing DML operations outside loops aligns with secure coding practices that the ApexCRUDViolation rule promotes, as it encourages developers to structure their DML operations in a way that can more easily incorporate proper CRUD/FLS checks when needed.